Bind the scrolling layout's column controls - #10529
Open
navsteruk wants to merge 1 commit into
Open
Conversation
SUPER + L switches a workspace into the scrolling layout, but nothing binds the two layout messages that layout is steered with, so it arrives without controls: there is no way to stack a window into a column, and no way to change a column's width. Windows get ten group bindings and twelve resize variants; the scrolling layout gets none. consume_or_expel builds and breaks the rows inside a column, and colresize +conf/-conf steps through scrolling:explicit_column_widths, which already ships as 0.333, 0.5, 0.667, 1.0 and had no way to reach it. consume_or_expel takes a direction, so it needs two bindings. A bare consume_or_expel binds and reloads without complaint and then fails at press time with "not enough args", which is why both directions are spelled out here rather than bound as one toggle. Brackets and backslash are not bound anywhere in default/hypr/bindings/ today, so these four take no key away from anything. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUPER + Lswitches a workspace into the scrolling layout, but nothing binds the two layout messages that layout is steered with, so it arrives without controls: there is no way to stack a window into a column, and no way to change a column's width. In the same file, windows get ten group bindings and twelve resize variants. The scrolling layout gets none.Four bindings in
default/hypr/bindings/tiling.lua:SUPER + \SUPER + SHIFT + \SUPER + ]SUPER + [colresize +confrather than a fraction.scrolling:explicit_column_widthsalready ships as0.333, 0.5, 0.667, 1.0, and+conf/-confstep through exactly that list. Nothing in the repo could reach it, so the setting was configurable and unreachable at the same time.consume_or_expelis two bindings, not one. It takes a direction. A bareconsume_or_expelbinds and reloads without complaint, then fails at press time withnot enough args— silent until pressed — so both directions are spelled out rather than bound as a single toggle.Keys. Brackets and backslash are not bound anywhere in
default/hypr/bindings/today, so these four take no key away from anything.Tests.
test/allon this branch: 3248 ok, 1 not ok. The one failure isbin commands use command helpers, which flagsbin/omarchy-remove-ai-hermesandbin/omarchy-remove-ai-openclaw. This branch touches neither, and I reproduced the same failure on a clean checkout ofquattroat a62e34e before opening this.